Skip to content

docs(settings): Removing the developerDocsUrl #56794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 2 commits into from
Jan 20, 2026
Merged

docs(settings): Removing the developerDocsUrl #56794

come-nc merged 2 commits into from
Jan 20, 2026
+8 −14

Conversation

@Arsalanulhaq
Copy link
Contributor

@Arsalanulhaq Arsalanulhaq commented Dec 2, 2025 •
edited
Loading

Summary

Removing the developerDocsUrl

Checklist

@Arsalanulhaq Arsalanulhaq requested review from a team as code owners December 2, 2025 11:45
@Arsalanulhaq Arsalanulhaq requested review from Copilot, leftybournes, salmart-dev, skjnldsv, sorbaugh, szaimen and yemkareems and removed request for a team December 2, 2025 11:45

This comment was marked as abuse.

Sign in to view

@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch from 212bc41 to 48e6ba0 Compare December 2, 2025 15:11
@Arsalanulhaq Arsalanulhaq changed the title Feat/hide developer docs conditionally Feat(settings): hide developer docs conditionally Dec 2, 2025
@Arsalanulhaq Arsalanulhaq changed the title Feat(settings): hide developer docs conditionally feat(settings): conditionally display developer documentation link based on configuration Dec 2, 2025
@szaimen szaimen requested review from susnux and removed request for szaimen December 2, 2025 15:17
@kesselb kesselb added enhancement 2. developing Work in progress labels Dec 4, 2025
kesselb
kesselb reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pr 🙏

@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch from 48e6ba0 to e69b649 Compare December 5, 2025 17:25
@Arsalanulhaq Arsalanulhaq requested a review from kesselb December 6, 2025 10:39
@printminion-co printminion-co force-pushed the feat/hide-developer-docs-conditionally branch from e69b649 to 9c46001 Compare December 8, 2025 13:22

This comment was marked as spam.

Sign in to view

@printminion-co printminion-co force-pushed the feat/hide-developer-docs-conditionally branch from 9c46001 to 370c02e Compare December 8, 2025 13:31
@kesselb
Copy link
Contributor

kesselb commented Dec 8, 2025

Hi @Arsalanulhaq,

We would prefer to drop the link from the apps store rather than adding a configuration option for it.

@Arsalanulhaq
Copy link
Contributor Author

Arsalanulhaq commented Dec 10, 2025 •
edited
Loading

Hi @Arsalanulhaq,

We would prefer to drop the link from the apps store rather than adding a configuration option for it.

Hi @kesselb
So, should we remove the generated developerDocsUrl link in AppsSettingsController.php and its usage in the AppStoreNavigation.vue file directly from the code? Is this link generated or used anywhere else? Because removing it will prevent users from seeing/navigating to the developer documentation.

come-nc
come-nc reviewed Dec 16, 2025
View reviewed changes
@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch from 370c02e to 51ae765 Compare December 16, 2025 09:46
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 30, 2025
@kesselb
Copy link
Contributor

kesselb commented Dec 30, 2025

Thank you @Arsalanulhaq 🙏

@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch from bf1be05 to 46858ef Compare December 31, 2025 10:16
@printminion-co printminion-co force-pushed the feat/hide-developer-docs-conditionally branch from 46858ef to b052c44 Compare January 5, 2026 11:26
@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch from b052c44 to 27d3189 Compare January 5, 2026 20:03
@come-nc
Copy link
Contributor

come-nc commented Jan 6, 2026 

1) OCA\Settings\Tests\Controller\AppSettingsControllerTest::testViewApps
Expectation failed for method name is "provideInitialState" when invoked 4 times.
Method was expected to be called 4 times, actually called 3 times.

2) OCA\Settings\Tests\Controller\AppSettingsControllerTest::testViewAppsAppstoreNotEnabled
Expectation failed for method name is "provideInitialState" when invoked 4 times.
Method was expected to be called 4 times, actually called 3 times.

tests needs to be adapted

@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch 5 times, most recently from c7c0aad to 302a366 Compare January 6, 2026 16:00
@Arsalanulhaq Arsalanulhaq changed the title feat(settings): conditionally display developer documentation link based on configuration docs(settings): Removing the developerDocsUrl Jan 7, 2026
@printminion-co printminion-co force-pushed the feat/hide-developer-docs-conditionally branch from 302a366 to 4ab4b81 Compare January 13, 2026 08:30
@Arsalanulhaq @printminion-co
docs: remove developer documentation link
02dc7f1 
Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
@printminion-co printminion-co force-pushed the feat/hide-developer-docs-conditionally branch from 4ab4b81 to 02dc7f1 Compare January 20, 2026 08:40
@come-nc
Copy link
Contributor

come-nc commented Jan 20, 2026

/compile /

@nextcloud-command
chore(assets): Recompile assets
c492b0d 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@come-nc come-nc merged commit 433e3da into master Jan 20, 2026
207 of 214 checks passed
@come-nc come-nc deleted the feat/hide-developer-docs-conditionally branch January 20, 2026 13:07
@printminion-co
Copy link
Contributor

printminion-co commented Jan 20, 2026

/backport to stable31

@backportbot backportbot bot mentioned this pull request Jan 20, 2026
Draft
2 tasks
@printminion-co
Copy link
Contributor

printminion-co commented Jan 20, 2026

/backport to stable32

@backportbot backportbot bot mentioned this pull request Jan 20, 2026
Draft
2 tasks
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@susnux susnux susnux approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Arsalanulhaq @kesselb @come-nc @printminion-co @susnux @sorbaugh @nextcloud-command